#17254: Upgrade to Singular-4-0-2
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-7.2
      Component:  packages:          |   Resolution:
  standard                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:  Jakob Kroeker,     |  Work issues:
  Jean-Pierre Flori, Jeroen Demeyer  |       Commit:
Report Upstream:  N/A                |  1426ad88ab3e8a3d72a75f952727deca44f951a7
         Branch:                     |     Stopgaps:
  u/jdemeyer/ticket.17254.squashed.latest|
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by jakobkroeker):

 Replying to [comment:177 jdemeyer]:
 > I cleaned up the patch and removed some unacceptable parts. Right now it
 doesn't build, that still needs to be fixed.


 Are these the unacceptable parts? (e.g  in
 src/sage/rings/polynomial/polydict.pyx)
 {{{
 diff --git a/src/sage/rings/polynomial/polydict.pyx
 b/src/sage/rings/polynomial/polydict.pyx
 index fd858f7..0b49f38 100644
 --- a/src/sage/rings/polynomial/polydict.pyx
 +++ b/src/sage/rings/polynomial/polydict.pyx
 @@ -506,7 +506,7 @@ cdef class PolyDict:
          don't put negative signs on the generators. ::

              sage: Integers(2)['x,y'].gens()
 -            (1*x, 1*y)
 +            (x, y)

          We make sure that intervals are correctly represented. ::

 }}}

 The 1*x output stems from Singular4 and that seems the new behaviour for
 that ring, for whatever reasons.

 same for
 {{{
 diff --git a/src/sage/rings/multi_power_series_ring_element.py
 b/src/sage/rings/multi_power_series_ring_element.py
 index 7293a91..7b9ca6e 100644
 --- a/src/sage/rings/multi_power_series_ring_element.py
 +++ b/src/sage/rings/multi_power_series_ring_element.py
 @@ -32,7 +32,7 @@ Power series arithmetic, tracking precision::
      sage: f*=s; f
      s + 2*s^2 + 3*s^3 + O(s, t)^8
      sage: f%2
 -    1*s + 1*s^3 + O(1*s, 1*t)^8
 +    s + s^3 + O(s, t)^8
      sage: (f%2).parent()
      Multivariate Power Series Ring in s, t over Ring of integers modulo 2

 @@ -1078,7 +1078,7 @@ class MPowerSeries(PowerSeries):
              sage: R.<a,b,c> = PowerSeriesRing(ZZ)
              sage: f = -a^3*b*c^2 + a^2*b^2*c^4 - 12*a^3*b^3*c^3 + R.O(10)
              sage: g = f % 2; g
 -            1*a^3*b*c^2 + 1*a^2*b^2*c^4 + O(1*a, 1*b, 1*c)^10
 +            a^3*b*c^2 + a^2*b^2*c^4 + O(a, b, c)^10
              sage: g in R
              False
              sage: g in R.base_extend(Zmod(2))
 }}}


 also floats are now put in braces,
 maybe because otherwise parsing the string '1.7E+30*5' in Singular would
 be wronng or fail? (just guessing)

 so removing the following hack
 {{{
 --- a/src/sage/rings/real_double.pyx
 +++ b/src/sage/rings/real_double.pyx
 @@ -689,21 +689,6 @@ cdef class RealDoubleElement(FieldElement):
              sage: RDF(10^100)
              1e+100
          """
 -        if isinstance(x,basestring):
 -            # a hack for parsing float strings beginning with braces
 -            if len(x)>2 and x.count('(')==1 and  x.count(')')==1:
 -                try:
 -                    if (x[0] == '(' or x[1] == '(') and x[-1] == ')':
 -                        if (x[0] == '-' and x[1] == '(') :
 -                            x = x[2:-1]
 -                            self._value = - float(x)
 -                            return
 -                        else:
 -                            x = x[1:-1]
 -                            self._value = float(x)
 -                            return
 -                except:
 -                    pass
          self._value = float(x)

      def _magma_init_(self, magma):
 }}}

 will result in a lot of failing doctests...

--
Ticket URL: <http://trac.sagemath.org/ticket/17254#comment:182>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to