#20284: A class to manage embedding between non-prime fields
-------------------------------------+-------------------------------------
       Reporter:  dlucas             |        Owner:
           Type:  enhancement        |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-7.3
      Component:  finite rings       |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Lucas        |    Reviewers:  Arpit Merchant
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dlucas/field_embedding           |  2492c313523014a07d88bc9af3809b96bf595700
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by arpitdm):

 * status:  needs_review => positive_review
 * reviewer:   => Arpit Merchant


Comment:

 I went through the reviewer's checklist and all the tests pass. The naming
 conventions are quite suitable and make it easier to interpret the
 functions. Giving it a positive review.

--
Ticket URL: <http://trac.sagemath.org/ticket/20284#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to