#20530: Add pictures to hyperbolic_geodesic.py
-------------------------------------+-------------------------------------
Reporter: jhonrubia6 | Owner:
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-7.3
Component: documentation | Resolution:
Keywords: documentation, | Merged in:
hyperbolic, geometry | Reviewers:
Authors: Javier Honrubia | Work issues:
González | Commit:
Report Upstream: N/A | 9b25a8217de93b8dda178e4767cc709bb0dbf1e4
Branch: | Stopgaps:
u/jhonrubia6/add_pictures_to_hyperbolic_geodesic_py|
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by jhonrubia6):
Replying to [comment:8 tscrim]:
> Here are my comments:
>
> - You have to deprecate `show` if you are going to outright remove it.
Ok
> - I'm -1 on using `show(P)` in the doctests; IMO it is better to return
the plot as it actually gets doctested in a fashion.
Ok, I also had my doubts.
> - Why this change:
> {{{#!diff
> - sage: g = HyperbolicPlane().PD().random_geodesic()
> + sage: PD = HyperbolicPlane().PD()
> + sage: g = PD.get_geodesic(-0.3+0.4*I,+0.7-0.1*I)
> }}}
> I think the random test is somewhat better. However, I think you
should add an additional test with this specific geodesic and give the
commands for the user to reproduce your picture.
Agreed. I changed the random_geodesic to make consistent and good-looking
into the doc. I think you are right, we better move the random_geodesic to
the test directive.
> - Can you explain this change:
> {{{#!diff
> - sage: h = PD.get_geodesic(4/5*I + 3/5, 9/13*I + 6/13)
> + sage: h = PD.get_geodesic(4/5*I + 3/5, I)
> }}}
Well, better looking picture I guess.
> - Replace {{{:math:`x^2+y^2-z^2=-1`}}} with {{{`x^2 + y^2 - z^2 =
-1`}}}.
Ok
> - I don't understand the point of the comments in the `.. PLOT::`
directives. Moreover, the numbering either has no meaning or it will loose
meaning as soon as someone adds another plot.
oops, it was debugging code, I'll remove it.
--
Ticket URL: <http://trac.sagemath.org/ticket/20530#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
