#20769: LatticePoset: Orthocomplements, part 1
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/orthocompletion | 51d4fd0e5ef01b019826b75f1ceb99603586ec18
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by kdilks):
At last, I have time to look at things. Preliminary comments:
* There should be some sort of definition as to what an orthocomplement
is.
* Correction to corner cases has a typo (ortohocomplement).
* This seems to be assuming that the elements of your poset are the
integers 1...n . Even if constructing the Hasse diagram ends up assigning
a labeling to the elements so the code works, it won't be clear to the
user what the output has to do with their original lattice.
* Orthocomplementations are only defined on complemented lattices. I'm not
sure if {{{is_complemented_lattice()}}} exists or is computationally
feasible (TODO?). At the very least the documentation should indicate that
the code might be returning the empty list for either reason. Even if a
check is computationally difficult, it should probably be included with an
optional parameter to skip checking.
--
Ticket URL: <http://trac.sagemath.org/ticket/20769#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
