#7159: [with patch, needs review] Graph.merge_vertices, and a bug in
edge_boundary
----------------------------+-----------------------------------------------
Reporter: ncohen | Owner: rlm
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.2.1
Component: graph theory | Keywords:
Work_issues: | Author:
Reviewer: | Merged:
----------------------------+-----------------------------------------------
Comment(by AJonsson):
I have looked at your new patch, and it seems good. The only thing I found
to object against was
{{{
if (v in vertices) and not (u in vertices) and v != vertices[0]:
}}}
If edge_boundary works as expected, the second test should not be needed
as u and v can never be in vertices at the same time. I attach a patch to
remove the unneeded test. It applies on top of your patch.
If you agree with this, you can count this as a positive review.
Replying to [comment:4 ncohen]:
> By the way, I can not find your email on the internet... It's good to
see new people in Sage's graph theory section !! What are you studying ?
I'm a student in mathematics and a bit of computer science. I use Sage for
diverse calculations in graph theory, and when I find that Sage can't do
all that I want it to, I have to do something about it ;-P
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7159#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
