#20850: AdditiveMagmas.ParentMethods.summation calls _add_ without checking
------------------------------+------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-7.3
Component: categories | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
------------------------------+------------------------
Description changed by jdemeyer:
Old description:
> In `src/sage/categories/additive_magmas.py`, there is
>
> {{{
> class AdditiveMagmas(Category_singleton):
> class ParentMethods:
> def summation(self, x, y):
> return x._add_(y)
> }}}
>
> It's dangerous to call `_add_` without checking. Either this should just
> be `x + y`, or there should be type checking for `x` and `y`.
New description:
In `src/sage/categories/additive_magmas.py`, there is
{{{
class AdditiveMagmas(Category_singleton):
class ParentMethods:
def summation(self, x, y):
return x._add_(y)
}}}
It's dangerous to call `_add_` without checking. Either this should just
be `x + y`, or there should be type checking for `x` and `y`, or there
should be conversion of `x` and `y` to the correct parent.
--
--
Ticket URL: <http://trac.sagemath.org/ticket/20850#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
