#20842: sage-uncompress-spkg takes ages
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: positive_review
Priority: blocker | Milestone: sage-7.3
Component: build | Resolution:
Keywords: | Merged in:
Authors: Volker Braun | Reviewers: John Palmieri, Karl-
Report Upstream: N/A | Dieter Crisman
Branch: | Work issues:
u/vbraun/sage_uncompress_spkg_takes_ages| Commit:
Dependencies: | 7f0356dc03a4394501da877fe0739bf34503a549
| Stopgaps:
-------------------------------------+-------------------------------------
Comment (by leif):
Replying to [comment:11 embray]:
> Replying to [comment:6 leif]:
> > It is still horrible regarding what its sole purpose is (namely to
extract ''all files'' from a usually sequentially read and written
archive, thereby eventually dropping a few files based on their names
which shouldn't at all be present anyway, but may have accidentally been
added by some MacOS user, without anybody noticing, probably not even
scripts that are supposed to avoid such things).
>
> This was indeed motivated specifically by #20717. Of course those files
shouldn't be there in the first place. But if they are, they
''definitely'' shouldn't be extracted.
The script though ''silently'' drops them; no warning, no error message.
Furthermore, there's absolutely no reason to sort the files by their
names, then extracting them in their original order, not only but
especially when there aren't any "OS-specific" files in the tarball (which
is the common case -- as you said, there shouldn't be any in the first
place).
While already the Python library's function name is "funny"
(extract'''all'''()), it's not necessary to pass an ''unmodified'' list of
all tarball entries to it in the "non-error" case.
--
Ticket URL: <http://trac.sagemath.org/ticket/20842#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
