#20559: InteractiveLPProblem, dictionaries: add_constraint / add_row methods
-------------------------------------+-------------------------------------
       Reporter:  mkoeppe            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.2
      Component:  linear             |   Resolution:
  programming                        |
       Keywords:                     |    Merged in:
        Authors:  Peijun Xiao,       |    Reviewers:  Andrey Novoseltsev
  Matthias Koeppe                    |
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  
u/mkoeppe/interactivelpproblem__dictionaries__add_constraint___add_row_methods| 
 7c93d94e81987b9eed1432cbbe04064444c86048
   Dependencies:  #20500             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Peijun Xiao, Matthias Koeppe', 'oldvalue': u'Peijun 
Xiao'}):

 * commit:  e3d934bde9cb612c76afacddd2d44611d24f175f =>
     7c93d94e81987b9eed1432cbbe04064444c86048
 * work_issues:  rebasing =>
 * author:  Peijun Xiao => Peijun Xiao, Matthias Koeppe


Comment:

 I've made some changes that address points 3 and 6.
 Also rebased on latest beta.
 Ready for review.
 ----
 New commits:
 
||[https://git.sagemath.org/sage.git/commit?id=1a931dd80072197691a9d75f60fb06be21b06bbc
 1a931dd]||{{{InteractiveLPProblem, dictionaries: add_constraint / add_row
 methods}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=f52596002f1c6160ab9d06d3c6ff1847e039bbe6
 f525960]||{{{add_row: Use @abstract_method}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=e5925a79c9f44ada3a4bfdcf0b6a602217549555
 e5925a7]||{{{fixup}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=6f41037165b476feebb077ca0a70e78e32d830c2
 6f41037]||{{{Rewording}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=e6404ab6e00c47c7a0c8fb913fa6ecc19391b6f8
 e6404ab]||{{{Preserve information when construct a new problem}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=6cb5622f81bd4af8e44d9d386e59312508e40f41
 6cb5622]||{{{The argument for new slack variable is optional}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=a8af9686b1136c2a9ce8b2143551665059e89416
 a8af968]||{{{Simplify code, don't create unnecessary rings}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=6d5f8615332af65715f5c6e19a7e5742df3ce7d1
 6d5f861]||{{{add_row methods: Rename slack_variable to basic_variable,
 new_b to constant}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=7c93d94e81987b9eed1432cbbe04064444c86048
 7c93d94]||{{{add_constraint: Delegate error checking to constructor}}}||

--
Ticket URL: <https://trac.sagemath.org/ticket/20559#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to