#20897: Fixes to SAGE_BANNER=bare support throughout
-------------------------------------+-------------------------------------
       Reporter:  embray             |         Type:  defect
         Status:  new                |     Priority:  major
      Milestone:  sage-7.3           |    Component:  user interface
       Keywords:                     |    Merged in:
        Authors:  Erik Bray          |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:  u/embray/sage-     |       Commit:
  banner                             |  41f98cff8fbc052dd7fd0e3951ffb3a0252f8baf
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
 #20322 fixed the standard `sage` CLI so that if `SAGE_BANNER=bare`, the
 simplified, non-unicode banner is displayed.

 However, there were several other places this directive was not obeyed.
 First `sage --help` would still display the full banner regardless.
 Second, the built-in `banner()` function (from what the banner file is
 generated) also does not obey `SAGE_BANNER=bare`.

 Because there is code that calls `banner()` directly, it should still only
 display the simplified banner if the `SAGE_BANNER=bare` variable is set in
 the environment (this is particularly relevant in the Docker container on
 Windows...)

 (This bug caused a live demo to fail!  (Mysteriously the same demo did not
 fail when I tested it minutes earlier....not sure why it suddenly
 changed))

--
Ticket URL: <https://trac.sagemath.org/ticket/20897>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to