#20811: Classes for points on generic curves
-------------------------------------+-------------------------------------
       Reporter:  gjorgenson         |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  minor              |    Milestone:  sage-7.3
      Component:  algebraic          |   Resolution:
  geometry                           |
       Keywords:  gsoc2016           |    Merged in:
        Authors:  Grayson Jorgenson  |    Reviewers:  Ben Hutz
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/gjorgenson/ticket/20811          |  bb7aa7c2f7cf6ef8a92cbcd5e5de8e106d1766c5
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by bhutz):

 * status:  needs_review => needs_work
 * reviewer:   => Ben Hutz


Comment:

 These classes seem fine in how they are structured. Also, since the
 functionality is calling the curve functionality, that all should be ok.
 However, I did come across of few things I would like some clarification
 on. First some minor issues.

 - no '.' for file title (first line)

 - curve() function - I don't see the point for creating this function.
 That is what codomain() does.

 - Return whether this point is or is not a singular point of the
 projective curve it is on.

 Remove the 'or is not' since the boolean it returns is in relation to 'is'


 ---

 Now for the more interesting questions:

 - Does multiplicity() work for higher dimensional varieties? Or perhaps
 'should' multiplicity work for higher dimensional varieties (just for
 points? or also higher dim subvarieties?) Maybe this is a candidate for a
 separate ticket.

 - I was trying to test this with a less standard example, the
 multiplicities of periodic points: graph intersect diagonal in the product
 space.

 {{{
 PP.<x,y,u,v>=ProductProjectiveSpaces(QQ,[1,1])
 G = PP.subscheme([(x^2-2*y^2)*u - y^2*v])
 D = PP.subscheme([x*v-y*u])
 Z=G.intersection(D)
 Z.dimension()
 }}}

 What do you think, should intersection_multiplicity() work here? Since
 we're working locally in an affine patch, this should be reasonably
 doable. This may be a candidate for a separate ticket since it is also
 unrelated to the class structure.

--
Ticket URL: <https://trac.sagemath.org/ticket/20811#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to