#20693: Sage crashes when inverting/dividing large number field elements
-------------------------------------+-------------------------------------
Reporter: ehlen | Owner:
Type: defect | Status: positive_review
Priority: critical | Milestone: sage-7.3
Component: number fields | Resolution:
Keywords: | Merged in:
Authors: Stephan Ehlen | Reviewers: Peter Bruin, Fredrik
| Stromberg
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/pbruin/20693-sage_crashes_when_computing_newforms|
eb3da684a613c81294dec6eff22972152950790f
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by fstromberg):
* status: needs_review => positive_review
* reviewer: Peter Bruin => Peter Bruin, Fredrik Stromberg
Comment:
I have gone through the proposed patch and everything seems to work as
stated.
* I ran `sage -t --all` and the few doctests which failed seems to not be
related to the proposed patch (and in particular all tests in sage -t
src/sage/rings/number_field/ passes).
* The example given above for level 23 crash on Sage 7.2 without the patch
and works fine with the patch.
* The new code introduced in
src/sage/rings/number_field/number_field_element.pyx is well-formatted and
does what is intended.
* The code which was removed from
src/sage/rings/number_field/number_field_element.pyx (i.e. the
'_invert_c_' routine) does indeed seem to have been unnecessarily
complicated.
* The new code introduce a test which crashes in Sage 7.2 without the
patch but passes with the patch.
--
Ticket URL: <https://trac.sagemath.org/ticket/20693#comment:52>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
