#19457: Generator for full binary trees
-------------------------------------+-------------------------------------
Reporter: patxiku | Owner: patxiku
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-7.1
Component: combinatorics | Resolution:
Keywords: binary trees, | Merged in:
full |
Authors: Adrien | Reviewers: Travis Scrimshaw,
Boussicault, Bérénice Delcroix- | Vincent Delecroix
Oger, Patxi Laborde-Zubieta |
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/full_binary_trees-19457|
a5ff26778a90e1a306840f0ade2e448b1e612dec
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
I don't think `to_full` should have such an argument and instead have it
be the bijection to full binary trees. If we wanted this extra
functionality, it would be better served as another method
`to_minimal_full`.
Perhaps as another option, we rename `to_full` to the more verbose
`to_full_binary_tree`. Although I do appreciate the more concise name.
Lastly, Vincent and I disagree with the inclusion of {{{``self``}}} in the
docstrings in general. I do agree that it should not appear in the INPUT:
block (unless special restrictions are needed), and I should have not
included it as such. However, the rest of the file uses {{{``self``}}}, so
I think that is a good case to continue using it in this file.
--
Ticket URL: <https://trac.sagemath.org/ticket/19457#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
