#20953: Improve minimum_distance for linear codes
-------------------------------------+-------------------------------------
       Reporter:  dlucas             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.3
      Component:  coding theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Lucas        |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dlucas/clean_minimum_distance    |  f0e15e476cb6c20afc843fe2e0664103220470d1
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'David Lucas', 'oldvalue': ''}):

 * status:  new => needs_review
 * commit:   => f0e15e476cb6c20afc843fe2e0664103220470d1
 * author:   => David Lucas


Comment:

 I pushed the branch, which contains the following changes:

 - renamed `min_wt_vec_gap` as `_minimum_weight_codeword`, moved it inside
 `AbstractLinearCode` (was a global method) and made it a private method.
 - Rewrote documentation of `_minimum_weight_codeword` and
 `minimum_distance`, removed useless doctests.
 - Removed a useless variable, factored some code.
 - Added a proper check when the user calls `algorithm="guava"`. If the
 user does not have Guava installed, it will fail with a proper error
 message instead of some random GAP error.

 This is open for review.

 Best,

 David
 ----
 New commits:
 
||[https://git.sagemath.org/sage.git/commit?id=b46774427ecc12bb9a24b3698012058439a1aa04
 b467744]||{{{Improved min_wt_vec_gap}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=a052919ebeb7c677dda2cc728af50a221291436a
 a052919]||{{{Reworked minimum_distance}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=f0e15e476cb6c20afc843fe2e0664103220470d1
 f0e15e4]||{{{Minor changes to the code}}}||

--
Ticket URL: <https://trac.sagemath.org/ticket/20953#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to