#9654: implicit_plot does not accept rgbcolor as keyword
-------------------------+-------------------------------------------------
       Reporter:  olazo  |        Owner:  olazo
           Type:         |       Status:  needs_review
  enhancement            |
       Priority:  minor  |    Milestone:  sage-7.3
      Component:         |   Resolution:
  graphics               |
       Keywords:         |    Merged in:
  implicit_plot          |
        Authors:  Paul   |    Reviewers:  Travis Scrimshaw
  Masson                 |
Report Upstream:  N/A    |  Work issues:
         Branch:         |       Commit:
  u/paulmasson/9654      |  01296816efffbc15c9ba8613f2c48f1aa3295d90
   Dependencies:         |     Stopgaps:
-------------------------+-------------------------------------------------
Changes (by tscrim):

 * commit:  ea98638e7b5d15b9f5b32f50144d576b339c8145 =>
     01296816efffbc15c9ba8613f2c48f1aa3295d90
 * reviewer:   => Travis Scrimshaw


Comment:

 Replying to [comment:13 paulmasson]:
 > I've updated the branch to raise a `ValueError` for conflicting input,
 as well as added a doctest.

 Thanks. Looks good.

 > The error in `plot.py` appears to arise from this line:
 >
 > {{{
 > @rename_keyword(color='rgbcolor')
 > }}}
 >
 > Once we agree on how to handle the two arguments here, I can remove that
 line and update the code accordingly.

 Which error where? I don't see any doctest failures.
 ----
 New commits:
 
||[https://git.sagemath.org/sage.git/commit?id=01296816efffbc15c9ba8613f2c48f1aa3295d90
 0129681]||{{{Add ValueError and doctest}}}||

--
Ticket URL: <https://trac.sagemath.org/ticket/9654#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to