#20936: Adding conversion for Divide and Product class in Sage/M2 interface
-------------------------------------+-------------------------------------
Reporter: zonova | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.3
Component: interfaces | Resolution:
Keywords: Macaulay2, | Merged in:
interface |
Authors: Saad Khalid | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/zonova/adding_conversion_for_divide_and_product_class_in_sage_m2_interface|
af1b40d505b981446ad79e76c28554a6759145aa
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by dimpase):
* status: needs_review => needs_work
Comment:
You should test your changes using Sage's doctesting framework. (`sage
-t`). With your branch I get
{{{
sage -t src/sage/interfaces/macaulay2.py
Error: TAB character found at lines 840,856,857,858,1190
[28 tests, 0.04 s]
----------------------------------------------------------------------
sage -t src/sage/interfaces/macaulay2.py # Tab character found
}}}
Do not use tabs, only use spaces for formatting (it should be easy to tell
your editor to map tab key to 4 spaces).
--
Ticket URL: <https://trac.sagemath.org/ticket/20936#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
