#20968: more Hadamard matrices with constant diagonal
-------------------------------------+-------------------------------------
Reporter: dimpase | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.3
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: Dima Pasechnik | Reviewers: Vincent Delecroix
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dimpase/hadaconst | 324fb166fe9f21872b25c08e8dd8c3d740efd616
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_review => needs_work
* reviewer: => Vincent Delecroix
Comment:
To get the squares in a finite field, there is better than
{{{
Q = filter(lambda a: a.is_square() and a.is_unit(), F)
}}}
Since you are using containment test later on I would even do
{{{
Q = set(a**2 for a in F)
Q.remove(F.zero())
}}}
For `szekeres_difference_set_pair`, it would be better to have the same
variable name in the documentation description and in the function
(currently `G` and `Q`).
Could you remove the trailing whitespaces in the whole file?
For the ` szekeres_difference_set_pair` and `typeI_matrix_difference_set`,
why not put it somewhere in `sage.combinat.designs.difference_family`?
You should add an example in
`regular_symmetric_hadamard_matrix_with_constant_diagonal` where your new
construction is actually used.
--
Ticket URL: <https://trac.sagemath.org/ticket/20968#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
