#16587: f(expr,hold).n() fails for all generalized functions
-------------------------+-------------------------------------------------
Reporter: rws | Owner:
Type: | Status: needs_review
defect |
Priority: major | Milestone: sage-7.3
Component: | Resolution:
symbolics |
Keywords: sgn, | Merged in:
evaluation |
Authors: Ralf | Reviewers: Paul Masson
Stephan |
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/rws/16587 | e7159eb400a9ddf09b36c7a7c2d4b42be24df3bd
Dependencies: | Stopgaps:
#17130, #17285 |
-------------------------+-------------------------------------------------
Comment (by rws):
Replying to [comment:26 paulmasson]:
> And for future reference, is it expected practice for people to merge
the current develop branch before pushing to Trac? Or is it a matter of
how the branch is assembled, especially for older tickets, and I just need
to pay attention to what gets pulled?
There should be as few merge commits as possible but you can't always
adhere to that.
As author, you of course need to merge if what you uploaded before doesn't
with develop (red link on ticket). But as you saw, there was a branch that
was so old that it could no longer be compiled so I needed to merge it
too. Note that as a reviewer you do not need to do `git trac checkout
12345; git merge develop` to get an up-to-date version of an older branch
(that still merges cleanly). You can also branch from develop and pull
changes: `git checkout -b tmp; git trac pull 12345`. This way your local
Sage is not changed to the version of the branch and only the specific
branch changes need to be compiled in.
So, to answer, in principle you need not merge the current develop branch
before pushing as long as the branch merges cleanly with develop. A good
reason to do it nevertheless would be that you want to make sure your
changes pass tests (which are always done by patchbot or the RM with
develop). What you want to pay attention to as reviewer OTOH is the age of
the last merge commit (or the first commit if none) and rather pull (see
above) than checkout if older than say 18 months.
--
Ticket URL: <https://trac.sagemath.org/ticket/16587#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
