#15024: Add Hankel functions and make spherical Bessel and Hankel functions
symbolic
-------------------------------------+-------------------------------------
Reporter: eviatarbach | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: symbolics | Resolution:
Keywords: | Merged in:
Authors: Eviatar Bach, | Reviewers: Paul Masson
Ralf Stephan |
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/rws/add_hankel_functions_and_make_spherical_bessel_and_hankel_functions_symbolic|
ab6006d7d04c8add865c48b1ecd0132a330bebd0
Dependencies: #18257 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by rws):
Replying to [comment:52 paulmasson]:
> Do I need to review again after conflict is resolved? What's the
protocol on this?
In principle I could have introduced any possible change with it, so yes.
But it is easy to check this, either per eyeball by skimming the diff
again, or automatically (I just tried this the first time ever):
{{{
git diff develop >diff1
git co 821c307 (the commit before the merge)
git diff 7.3.beta6 >diff2
diff -u diff2 diff1
}}}
The output of the last diff should not contain lines that start with
`++/+-/-+/--`. This way I found I somehow introduced some `orig` files
into the branch so I'll delete those files. But as introducing and
removing these files create completely unnecessary data I'll upload a new
branch with an improved merge commit.
--
Ticket URL: <https://trac.sagemath.org/ticket/15024#comment:54>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.