#20897: Fixes to SAGE_BANNER=bare support throughout
-------------------------------------+-------------------------------------
Reporter: embray | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: user interface | Resolution:
Keywords: | Merged in:
Authors: Erik Bray | Reviewers:
Report Upstream: N/A | Work issues:
Branch: u/embray/sage- | Commit:
banner | 4314e4ab786dbd1120ef143cce518f4cd9fcca11
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by embray):
Replying to [comment:13 chapoton]:
> Replying to [comment:12 embray]:
> > Why? What's wrong with that change?
>
> Maybe it's ok, but it will just take me more time to check that, for
something not so important..
There is already code
[https://git.sagemath.org/sage.git/tree/src/sage/misc/banner.py?id=1ade53383dec21e76b7b00ffc031c30b7a5ddfee#n18
here] which prints the exact same thing as the `echo "SageMath version
$SAGE_VERSION, Release Date: $SAGE_RELEASE_DATE"`. I see no point in
having two things that produce the same output.
The only reason I replace it with `banner(full=False)` instead of
`version()` is for symmetry.
`banner()` was updated to wrap `version()` (by way of `full=False`) to
incorporate consistent handling of the `SAGE_BANNER` environment variable,
as `banner()` is already called in a few other parts of the code
(including by sagenb) without respecting `SAGE_BANNER`.
--
Ticket URL: <https://trac.sagemath.org/ticket/20897#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
