#20727: LatticePoset: about complements
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers: Travis Scrimshaw
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/hasse_complements | 2481a494167fa56b15742fd9b507559232517069
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jmantysalo):
First, thanks for reviews!
Replying to [comment:6 kdilks]:
> I think it definitely needs to be defined in {{{hasse_diagram.py}}}, to
distinguish between the inherited method of {{{complement()}}} coming from
{{{Digraphs}}}, which is entirely different.
This patch will do that. Althought I must admit that now `lattices.py`
copies code from `hasse_diagram.py`, and that is not needed.
> For the other ones, I would include a line at the end of each linking to
similar/relevant methods (ie, {{{is_complemented()}}} would have a line at
the end saying {{{see: complements(), is_relatively_complemented(),
etc.}}}.
True. I guess that #20940 will be last of this serie, so it is propably
right place to add seealso-links. Before that I wait comment from Travis
at #20972.
--
Ticket URL: <https://trac.sagemath.org/ticket/20727#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
