#7308: [with spkg, needs review] cliquer's spkg-install does not work on cygwin
-----------------------+----------------------------------------------------
Reporter: mhansen | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone:
Component: cygwin | Keywords: cliquer
Work_issues: | Author: Mike Hansen
Reviewer: | Merged:
-----------------------+----------------------------------------------------
Comment(by drkirkby):
I'm not in a position to test this, but if you need to make any changes, I
would suggest the following would be helpful. Some are I admit code I
introduced, which is probaby not necessary. None are particularly
important.
* There is no longer any need to have
{{{
if [ -n "$SAGE_FORTRAN_LIB" ] && [ ! -e "$SAGE_FORTRAN_LIB" ]; then
echo "SAGE_FORTRAN_LIB is defined as $SAGE_FORTRAN_LIB, but does not
exist"
exit 1
fi
}}}
since code in the recent ''prereq-0.4'' (#7021) script checks this, so the
above code is redundant.
* There is no need to have the following line
{{{ if [ "x$SAGE64" = "xyes" ] || [ "x$SAGE64" = "x1" ]; then }}}
It should instead be replaced by
{{{ if [ "x$SAGE64" = "xyes" ]; then }}}
since some earlier code in the ''prereq-0.3'' script written by William
only allows SAGE64 to be unset, or set to ''yes'' or ''no''. It is not
possible to set it to ''1'', so there is no point testing if it is ''1''.
The same behaviour is followed in my recent updated to prereq-0.4 (#7021)
and also to prereq-0.5 which I have awaiting review (#7352)
* There is no need to have
{{{
# We exit here, since we are possibly on an unsupported platform.
if [ -n "${SAGE_PORT:-x}" ]; then
echo "Cannot determine your platform or it is not supported...
exiting"
exit 1
else
}}}
since the recent ''prereq-0.4'' update will exit for '''all''' unsupported
platforms unless SAGE_PORT is set to 'yes'.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7308#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
