#20816: pep8 in magma interface
-------------------------------------+-------------------------------------
       Reporter:  chapoton           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.3
      Component:  interfaces:        |   Resolution:
  optional                           |
       Keywords:  magma              |    Merged in:
        Authors:  Frédéric Chapoton  |    Reviewers:  Travis Scrimshaw
Report Upstream:  N/A                |  Work issues:
         Branch:  u/chapoton/20816   |       Commit:
                                     |  cd6daf2a45bcf981f04d7c95ede61ee30c27b116
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):

 * reviewer:   => Travis Scrimshaw


Comment:

 LGTM modulo this change:
 {{{#!diff
 -            sage: v = V.list_attributes(); v.sort(); v               #
 optional - magma
 -            ['Coroots', 'Involution', 'M', 'RootDatum', 'Roots',
 'StrLocalData', 'T', 'decomp', 'eisen', 'exthom', 'hSplit', 'ip_form',
 'p', 'ssbasis', 'weights']
 +            sage: v = V.list_attributes(); v.sort()               #
 optional - magma
 +            sage: print(v)     # optional - magma
 +            ['Coroots', 'Involution', ..., 'p', 'ssbasis', 'weights']
 }}}
 Is there a reason why we don't keep all of them (I don't have magma so I
 can't check)? Also, the `print` is vacuous to me.

--
Ticket URL: <https://trac.sagemath.org/ticket/20816#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to