#20611: More functions for mq.SBox and helper to build a Feistel/MISTY 
constructed
S-Box
-------------------------------------+-------------------------------------
       Reporter:  ruhm               |        Owner:
           Type:  enhancement        |       Status:  new
       Priority:  major              |    Milestone:  sage-7.3
      Component:  cryptography       |   Resolution:
       Keywords:                     |    Merged in:
        Authors:                     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/ruhm/improved_sbox               |  96832f793fec97e01c56948c8f288753b5fe3c56
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ylchapuy):

 * commit:   => 96832f793fec97e01c56948c8f288753b5fe3c56


Comment:

 Hi,\\
 You might want to use more pythonic syntax e.g.


 {{{#!python
 def substitute(x):
     mask = (1 << b) - 1
     xl = (x >> b) & mask
     xr = x & mask
     for sb in sboxes:
         xl, xr = sb(xl) ^ xr, xl
     return (xl << b) | xr
 }}}

 also in my opinion {{{is_bent}}} should return {{{False}}} instead of
 raising {{{ValueError}}}.
 ----
 New commits:
 
||[https://git.sagemath.org/sage.git/commit?id=5ed03fa7ae556771adb834714b864d6c2c64c0bd
 5ed03fa]||{{{initial commit}}}||
 
||[https://git.sagemath.org/sage.git/commit?id=96832f793fec97e01c56948c8f288753b5fe3c56
 96832f7]||{{{merge develop with t/20611/improved_sbox}}}||

--
Ticket URL: <https://trac.sagemath.org/ticket/20611#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to