#20902: Move Parent.list() method to Sets category
-------------------------+-------------------------------------------------
Reporter: klee | Owner:
Type: | Status: needs_review
defect |
Priority: major | Milestone: sage-7.3
Component: | Resolution:
categories |
Keywords: | Merged in:
Authors: | Reviewers:
Kwankyu Lee |
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/klee/20902 | 6a36fa0c3c2c058c9dfb9dff74719174838c1a04
Dependencies: | Stopgaps:
-------------------------+-------------------------------------------------
Changes (by jsrn):
* cc: jsrn, nbruin, vbraun, jdemeyer, tscrim, nthiery (added)
Comment:
I have some issues with this:
* You are arguing that these functions **should** be in `EnumeratedSets`,
but you move them to `Sets`. Why not move them to `EnumeratedSets` and
start adding parents to that category? At least, you should keep the TODO
that this would be best?
* The `list` function now returns a copy of the (cached) list every time.
We had a long discussion on sage-devel as well as on #20743 about this,
and though complete consensus didn't arise, everyone seemed to think that
`list` should **not** return a fresh copy every time. Rather we should
somehow flag the list as being immutable.
Apart from that it makes sense to move those functions from `Parent`.
(I added a few of the debators on #20743 to Cc, hope you're all ok with
that).
--
Ticket URL: <https://trac.sagemath.org/ticket/20902#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.