#7332: Escape css id's and classes in templates
----------------------------+-----------------------------------------------
Reporter: timdumol | Owner: boothby
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.2.1
Component: notebook | Keywords:
Work_issues: | Author: Tim Dumol
Reviewer: Mitesh Patel | Merged:
----------------------------+-----------------------------------------------
Changes (by mpatel):
* reviewer: => Mitesh Patel
Comment:
Version 3:
* Rebased against #7309, #7310. For some reason, I got
{{{
applying trac_7332-css-escape.2.patch
patching file sagenb/notebook/template.py
Hunk #1 FAILED at 15
Hunk #3 FAILED at 75
2 out of 3 hunks FAILED -- saving rejects to file
sagenb/notebook/template.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
}}}
but the failures were inconsequential.
* Fixes the overall checkbox in `notebook_lib.js`.
To the extent it counts, my review is positive.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7332#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
