#21064: Enable NTL's '-march=native' more cautiously
-------------------------------------+-------------------------------------
       Reporter:  leif               |        Owner:  leif
           Type:  defect             |       Status:  needs_review
       Priority:  blocker            |    Milestone:  sage-7.3
      Component:  packages:          |   Resolution:
  standard                           |
       Keywords:  assembler shlx     |    Merged in:
  mulx                               |
        Authors:  Leif Leonhardy     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/leif/enable_NTL_native_more_safely|  
7e1ceb270804b7525db553d35be29ccecc03206a
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by leif):

 Replying to [comment:6 dunfield]:
 > One very minor quibble with the OS X-specific comment in the spkg-
 install file:
 >
 > {{{
 > TODO: If we pass '-q', it suddenly becomes LLVM's 'as', which should
 work.
 > }}}
 >
 > It is true that NTL will compile if you add `-q`, but I wouldn't
 recommend doing so just for NTL, only Sage as a whole; I've seen weird
 segfaults when I've tried mixing the two assemblers...

 Better this way?
 {{{
 #!diff
 diff --git a/build/pkgs/ntl/spkg-install b/build/pkgs/ntl/spkg-install
 index 0a35355..cb5ad4e 100755
 --- a/build/pkgs/ntl/spkg-install
 +++ b/build/pkgs/ntl/spkg-install
 @@ -109,8 +109,7 @@ ntl_configure()
                  assembler_ok=true # perhaps until we upgrade Sage's
 GCC... ;-)
                  ;;
                1.38) # This is Apple's ancient version of GNU as.
 -                # TODO: If we pass '-q', it suddenly becomes LLVM's 'as',
 which
 -                #       should work.
 +                # If we passed '-q', it would suddenly become LLVM's
 'as'.
                  ;;
              esac
          elif [ -n "$LLVMAS_VERSION" ]; then
 }}}

 (The
 
[https://git.sagemath.org/sage.git/commit?id=7e1ceb270804b7525db553d35be29ccecc03206a
 corresponding commit message] is more explicit.)

--
Ticket URL: <https://trac.sagemath.org/ticket/21064#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to