#21086: new style package for database_kohel
-------------------------------------+-------------------------------------
Reporter: vdelecroix | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.3
Component: packages: | Resolution:
optional |
Keywords: | Merged in:
Authors: Vincent Delecroix | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/vdelecroix/21086 | e6902ed430e889bdc76106e898f9007d4a8ff346
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => needs_work
Comment:
1. You need to check for errors in `spkg-install` (in particular, the `mv`
commands).
2. You can replace
{{{
if [ -d ${TARGET} ]
then
echo "REMOVING PREVIOUS VERSION"
rm -rf ${TARGET}
fi
}}}
by
{{{
rm -rf ${TARGET}
}}}
3. I don't like this error handling:
{{{
try:
coeff_list = _dbz_to_integer_list(modpol)
except IOError:
raise KeyError("No database entry for modular polynomial of
level %s"%level)
}}}
I think it would be better to raise the error directly in
`_dbz_to_integer_list` and then only if the file really cannot be opened.
If the error is raised while reading the file, it should be propagated as
`IOError`. I also think that `KeyError` is not really appropriate, since
it's not a key. I would prefer `LookupError`.
--
Ticket URL: <https://trac.sagemath.org/ticket/21086#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
