#21098: Restore patch to PPL for Cygwin64 support
-------------------------------------+-------------------------------------
Reporter: embray | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: porting: Cygwin | Resolution:
Keywords: | Merged in:
Authors: Erik Bray | Reviewers:
Report Upstream: Reported | Work issues:
upstream. No feedback yet. |
Branch: u/embray/ppl- | Commit:
cygwin-patch | e2d2a54e5c2cc32fcf28dfab77fc5e38d2aef1ba
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by embray):
* upstream: Not yet reported upstream; Will do shortly. => Reported
upstream. No feedback yet.
Old description:
> This patch was originally #16152, but was mistakenly removed in #20927.
> This patch is still needed to build PPL in Cygwin (the patch just needed
> to updated slightly for PPL 1.2).
>
> A better patch would be to modify the autoconf files to not set
> `PPL_CXX_SUPPORTS_ATTRIBUTE_WEAK` in the first place on Cygwin64--as it
> is using `__attribute__((weak))` will compile fine, but fails to work
> properly at link time. Not sure whether it's worth it though.
New description:
This patch was originally #16152, but was mistakenly removed in #20927.
This patch is still needed to build PPL in Cygwin (the patch just needed
to updated slightly for PPL 1.2).
A better patch would be to modify the autoconf files to not set
`PPL_CXX_SUPPORTS_ATTRIBUTE_WEAK` in the first place on Cygwin64--as it is
using `__attribute__((weak))` will compile fine, but fails to work
properly at link time. Not sure whether it's worth it though.
Reported upstream at https://www.cs.unipr.it/mantis/view.php?id=1690
Although this is more deeply an issue with Cygwin, it's a pretty difficult
to resolve one, while easy enough to workaround.
--
--
Ticket URL: <https://trac.sagemath.org/ticket/21098#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
