#20933: Update MathJax and other spkgs' patches to conform to same format as
other
patches
-------------------------------------+-------------------------------------
Reporter: embray | Owner:
Type: defect | Status: positive_review
Priority: minor | Milestone: sage-7.3
Component: packages: | Resolution:
standard |
Keywords: | Merged in:
Authors: Erik Bray | Reviewers: Jeroen Demeyer
Report Upstream: N/A | Work issues:
Branch: u/jdemeyer/patch- | Commit:
normalization-2 | 86279c4146a13f060f3ce05017478c499860ed59
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):
* status: needs_review => positive_review
* commit: 7e13bb1600064a2773cb766f3286432fc8b29a2b =>
86279c4146a13f060f3ce05017478c499860ed59
Old description:
> #20837 tried to bring all spkgs into a uniform format for patches to the
> upstream sources. In particular it ensures that all patches are applied
> from within the root of the upstream sources.
>
> In the process I missed a few more packages that were a bit unusual.
>
> The following packages were patching from a different directory than
> `src`:
>
> * atlas
> * mathjax
> * ntl
> * singular
>
> The following packages were copying complete files instead of using
> patches:
>
> * jmol
> * rubiks
> * tachyon
>
> I have updated these packages to use the new "standard" patch format, so
> this can be considered a followup to #20837. Fixing this is needed for
> #20692 to be completed.
New description:
#20837 tried to bring all spkgs into a uniform format for patches to the
upstream sources. In particular it ensures that all patches are applied
from within the root of the upstream sources.
In the process I missed a few more packages that were a bit unusual.
The following packages were patching from a different directory than
`src`:
* atlas
* mathjax
* ntl
* singular
The following packages were copying complete files instead of using
patches:
* jmol
* tachyon
* rubiks: not in this ticket, see #21103
I have updated these packages to use the new "standard" patch format, so
this can be considered a followup to #20837. Fixing this is needed for
#20692 to be completed.
--
Comment:
New commits:
||[https://git.sagemath.org/sage.git/commit?id=23131e7862aa7b50dad16fded9a83a93826d8b07
23131e7]||{{{Rewrite Singular patches to comply to the new standard
format}}}||
||[https://git.sagemath.org/sage.git/commit?id=c863b90459a0e57eab1c2641646237e2774f246f
c863b90]||{{{Make tachyon conform to the standard patch format.}}}||
||[https://git.sagemath.org/sage.git/commit?id=86279c4146a13f060f3ce05017478c499860ed59
86279c4]||{{{Make NTL and singular 'more standard'}}}||
--
Ticket URL: <https://trac.sagemath.org/ticket/20933#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
