#21103: Update rubiks' patches to conform to same format as other patches
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.3
Component: packages: | Resolution:
standard |
Keywords: | Merged in:
Authors: Erik Bray | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jdemeyer/update_rubiks__patches_to_conform_to_same_format_as_other_patches|
a1a09b844984a8dbb9bd5597f27507ccd206d787
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
I am not really convinced that the non-patched `Makefile`s are fine.
Surely, the person who patched them must have had a reason for it. There
is for example this comment in `build/pkgs/rubiks/patches/dietz-solver-
Makefile`:
{{{
# This Makefile was seriously broken.
# CC was set to g++. Since it was compiling C++ files,
# CXX should have been used.
# LINK was set to g++, so I changed that to LD
# CFLAGS was set to -O2. I've removed that, so it can be set
# in spkg-install.
# In any case, it should have been CXXFLAGS
# LFLAGS and INCLUDES were both empty
# David Kirkby, 29th Sept 2009
}}}
--
Ticket URL: <https://trac.sagemath.org/ticket/21103#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
