#6781: [with patch, needs review] Library access to ecl
---------------------------+------------------------------------------------
Reporter: nbruin | Owner: nbruin
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.2.1
Component: packages | Keywords:
Work_issues: | Author:
Reviewer: | Merged:
---------------------------+------------------------------------------------
Changes (by kcrisman):
* status: needs_review => needs_work
Comment:
So far, this looks good. For some reason I am having trouble with #7287
working properly, and it's possible this is to blame, but this patch on
its own seems ok. I can't give it a positive review, because I do not
know enough about Lisp to competently judge it, but various tests I got
from random Lisp websites for things not in the doctests also gave correct
answers, which is good!
A couple of very minor things: I notice a few functions in the 800s which
aren't separated by a blank line, which makes it harder to read. There is
also a typo in init_ecl - it should be "Do not", not "No not". I also
occasionally get output like this:
{{{
sage: ecl_eval("(command object)");
outputsage:
}}}
as opposed to
{{{
sage: ecl_eval("(command object)");
output
sage:
}}}
I can't determine very well when this happens, though it seems to occur
fairly reliably after various print commands, like
{{{
sage: ecl_eval("(print 3)") ;
3 sage:
}}}
Note that if I don't use the ;, since it returns the ECL object, I don't
have the problem then:
{{{
sage: ecl_eval("(print 3)")
3 <ECL: 3>
sage:
}}}
So I'm putting this to "needs work" because of these very minor issues,
but really it seems good and we just need someone who knows something
about Lisp to review it! Looks nice.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6781#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
