#21109: Faster meet() for lattice
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-7.3
Component: combinatorics | Resolution:
Keywords: lattice poset | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: u/jmantysalo | Commit:
/faster-meet | 965b8ab193baca00cfd8af7b7d9ac17db5060662
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jmantysalo):
* status: needs_work => needs_review
Comment:
Replying to [comment:3 chapoton]:
> Could you take the opportunity to make the method fully pep8 compliant ?
only the line
> {{{
> raise ValueError("No meet for x=%s y=%s"%(x,y))
> }}}
> must be changed to
> {{{
> raise ValueError("No meet for x=%s y=%s" % (x, y))
> }}}
Changed. Then there is the error message formatting question... Python
exceptions start with lowercase and do not end to a period. But this has
been discussed in sage-devel without clear conclusion.
> I do not understand the comment {{{# T = {x_i \wedge z : z>-x_k}}}}
> What is the meaning of `>-` ?
I guess it has meant covering. I removed it.
> Does lc stands for "lower covers" ? if yes, that would be worth to say
in a comment
Done.
--
Ticket URL: <https://trac.sagemath.org/ticket/21109#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
