#6775: [with patch, needs work] Create an interface for Disjoint Set data
structure
-----------------------------+----------------------------------------------
   Reporter:  slabbe         |       Owner:  slabbe                     
       Type:  defect         |      Status:  needs_work                 
   Priority:  major          |   Milestone:  sage-4.2.1                 
  Component:  combinatorics  |    Keywords:  disjoint set data structure
Work_issues:                 |      Author:                             
   Reviewer:                 |      Merged:                             
-----------------------------+----------------------------------------------

Comment(by rlm):

 1. You should probably declare things like
 {{{
 cdef class DisjointSet_of_integers(SageObject):
     cdef OrbitPartition *_nodes
 }}}
 and
 {{{
 cdef class DisjointSet_of_hashable(SageObject):
    cdef list _int_to_el
    cdef dict _el_to_int
    cdef DisjointSet_of_integers _d
 }}}
 in `disjoint_set.pxd` instead of `disjoint_set.pyx`. That'll make it
 easier to use these classes elsewhere.

 2. You should have `__del__` print something and see if it's even getting
 called. I would define `__dealloc__` and see if that gets called instead.
 You're using `OP_dealloc` correctly.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6775#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to