#5324: notebook -- %time block bug
------------------------+---------------------------------------------------
Reporter: was | Owner: mhansen
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.2.1
Component: notebook | Keywords:
Work_issues: | Author:
Reviewer: | Merged:
------------------------+---------------------------------------------------
Changes (by mhampton):
* status: needs_review => positive_review
Comment:
Looks good and seems to fix the problem. What's the point of setting i=-1
in the patch? Is that just so i is defined as an integer if text has no
elements when reaching the line: return "\n".join(text[i:]).strip()?
Setting i = 0 would seem to make slightly more sense, if so. I'm just
curious, that doesn't seem like enough of an issue to block a positive
review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5324#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
