#7414: improve {from,to}_inversion_vector and to_lehmer_code
------------------------------+---------------------------------------------
Reporter: ylchapuy | Owner: mhansen
Type: defect | Status: positive_review
Priority: major | Milestone: sage-combinat
Component: combinatorics | Keywords: permutations, inversion vector,
lehmer code
Work_issues: | Author: Yann Laigle-Chapuy
Reviewer: Florent Hivert | Merged:
------------------------------+---------------------------------------------
Changes (by hivert):
* status: needs_review => positive_review
Comment:
Good work ! Positive review.
Some remarks:
- as you commented in the code the hardcoded handling of the n=0,1,2,3
case is a little bit overkill :-)
- we should'nt spent too much time in optimizing very finely those
function since at some point, we will probably change the datastructure
for permutations to a fastest one (plain python list or tuple or Cython
object or even C int[]).
Cheers,
Florent
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7414#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
