#7364: Eulerian orientation of a graph
----------------------------+-----------------------------------------------
Reporter: ncohen | Owner: rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3
Component: graph theory | Keywords:
Work_issues: | Author:
Upstream: N/A | Reviewer: Florent Hivert
Merged: |
----------------------------+-----------------------------------------------
Changes (by hivert):
* reviewer: => Florent Hivert
* upstream: => N/A
Comment:
Hi Nathann
Patch looks good. All tests passed! I'm ready to put a Positive review.
However, I'm not a graph expert so I've no idea how clever is the
algorithm.
So maybe it should be reviewed by a graph expert. Speaking about clever
algorithm, if the complexity is known and in particular if it's known to
be optimal or not, it could be a good idea to put a "..note:" in the doc
giving this information. Of course the preceding remarks apply to any
graph algorithm (and even to any algorithm). So maybe you want to put a
positive review anyway.
Cheers,
Florent
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7364#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=.
