#5396: [with patch, needs review] Wrapping lcalc library
-----------------------------+----------------------------------------------
Reporter: rishi | Owner: Rishi
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.3
Component: number theory | Keywords: lcalc
Work_issues: | Author:
Upstream: N/A | Reviewer:
Merged: |
-----------------------------+----------------------------------------------
Changes (by ylchapuy):
* upstream: => N/A
Comment:
I hope you won't mind, but I refactored a little bit your code to address
reviewers comments.
In the provided patch:
* the different L-functions derive from a base class
* all doctests are protected against numerical noise
* I removed the file for_testing.py and incorporated the (renamed)
functions in the main file
( they could be moved to better places though )
* added a __repr__ method (which is minimalistic)
After spkg install, only my patch needs to be applied.
Please let me know your opinion about all these.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5396#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
