#7490: refactor symbolic functions
-------------------------+--------------------------------------------------
Reporter: burcin | Owner: burcin
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.3
Component: symbolics | Keywords: pynac
Work_issues: | Author: Burcin Erocal
Upstream: N/A | Reviewer: Mike Hansen
Merged: |
-------------------------+--------------------------------------------------
Changes (by mhansen):
* status: needs_review => needs_work
* reviewer: => Mike Hansen
Comment:
Here's my review.
There are a number of things which break old code -- they should be
deprecated first.
{{{
- exp(2,prec=100), gamma(pi,prec=100), etc.
- sage: Q.<i> = NumberField(x^2+1)
sage: gamma(i)
sage: gamma(QQbar(I))
}}}
Conversion of polylog to maxima is broken:
{{{
sage: polylog(2, x)._maxima_init_()
'polylog(2,x)'
}}}
instead of {{{'li[2](x)'}}}.
Some doctests are missing:
{{{
sage/interfaces/maxima.py: _symbolic_
sage/rings/number_field/number_field_element.pyx: _mpfr_, __complex__
}}}
Why do you have to use
{{{
f = CallableConvertMap(RR, RR, lambda x: x.exp(),
parent_as_first_arg=False)
}}}
instead of
{{{
f = CallableConvertMap(RR, RR, exp, parent_as_first_arg=False)
}}}
, which is more natural?
In expression.pyx, some things are missing from the _convert docstring.
Also, f._convert(int) gives {{{-0.989992496600445*sqrt(2)}}} which seems
unexpected. Maybe the docstring can be clarified further?
Finally, there are some numerical issues it seems with evaluations:
complex(I) gives 0.99999999999999967j instead of 1j. I'm not sure where
the discrepancy is occurring.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7490#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
