#6679: Vertex Coloring, Edge Coloring
----------------------------+-----------------------------------------------
   Reporter:  ncohen        |       Owner:  rlm            
       Type:  enhancement   |      Status:  needs_review   
   Priority:  major         |   Milestone:  sage-4.3       
  Component:  graph theory  |    Keywords:                 
Work_issues:                |      Author:  Nathann Cohen  
   Upstream:  N/A           |    Reviewer:  Minh Van Nguyen
     Merged:                |  
----------------------------+-----------------------------------------------
Changes (by newvalueoldvalue):

  * reviewer:  => Minh Van Nguyen
  * author:  => Nathann Cohen


Comment:

 The patch `trac_6679.patch` applies OK against Sage 4.3.alpha0. All
 doctests pass with the options `-t -long`, apart from the following known
 doctest failure:
 {{{
 sage -t -long devel/sage/sage/interfaces/maxima.py # 1 doctests failed
 }}}
 The doctests also pass with the optional packages `cbc-2.3.p0` and
 `glpk-4.38.p2`, again with the above failure. In the function
 `first_coloring`(), the function signature states that `hex_colors=True`,
 which means that `hex_colors` is `True` by default. Yet, the documentation
 of this keyword claims otherwise. I have adjusted the documentation and
 value of `hex_colors` accordingly. However, it's crucial that you check my
 changes because in the function `coloring()` its default value is `False`.
 I have attached the reviewer patch `trac_6679-reviewer.patch`. Only my
 patch needs review. You should apply patches in this order:

  1. `trac_6679.patch`
  1. `trac_6679-reviewer.patch`

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/6679#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to