#7604: Bug in continued fractions module (contfrac). New patch attached
---------------------------------------------------------+------------------
Reporter: solevillar | Owner:
AlexGhitza
Type: defect | Status:
needs_review
Priority: minor | Milestone:
Component: algebra | Keywords:
contfrac
Work_issues: | Author:
Upstream: Reported upstream. Little or no feedback. | Reviewer:
Merged: |
---------------------------------------------------------+------------------
Comment(by fwclarke):
There are several problems:
1. The attachment is not actually a patch but a new version of the
`contfrac.py` file.
2. The change to `is_field` to remove the optional parameter `proof=True`
is unhelpful since every other instance of `is_field` has the argument
proof, and Sage contains code which uses this argument and will crash
without it.
3. At lines 456-457 the line n = ZZ(n) has been duplicated. In fact this
line is not needed at all.
4. The correction of the bug is a bit more complicated than necessary.
I have attached a patch which deals with the bug, and have made a minor
change to a doctest so that it would have detected the bug.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7604#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
