#7452: Make it easier to diagnose build problems by allowing copy-paste
---------------------------+------------------------------------------------
Reporter: iandrus | Owner: tbd
Type: enhancement | Status: needs_work
Priority: trivial | Milestone: sage-4.3
Component: build | Keywords:
Work_issues: | Author: Ivan Andrus
Upstream: N/A | Reviewer: Minh Van Nguyen
Merged: |
---------------------------+------------------------------------------------
Changes (by mvngu):
* status: positive_review => needs_work
Comment:
Replying to [comment:4 iandrus]:
> If I am allowed to review the rebased patch, I give it a positive
review.
Yes, I think you are allowed to review my rebased patch. Essentially, I'm
happy with your original patch and I would give it a positive review. But
I can't successfully apply your patch to Sage 4.3.alpha1 so I had to
rebase your patch. What you are doing is reviewing the modification I made
to your patch.
[[BR]][[BR]]
> The only nit that I have it is uses tabs, but there are other tabs in
this file as well.
My apology about introducing the tabs. I have attached a new patch which
shouldn't have any tabs in it. Only that newer patch needs reviewing.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7452#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
