#7267: Add a compact color picker to SageNB
---------------------------+------------------------------------------------
   Reporter:  mpatel       |       Owner:  boothby        
       Type:  enhancement  |      Status:  positive_review
   Priority:  minor        |   Milestone:  sage-4.3       
  Component:  notebook     |    Keywords:                 
Work_issues:               |      Author:  Mitesh Patel   
   Upstream:  N/A          |    Reviewer:                 
     Merged:               |  
---------------------------+------------------------------------------------
Changes (by was):

  * status:  needs_review => positive_review


Comment:

 REFEREE REPORT:

 1. General remark/question.  Is there any way we can get rid of stuff like
 this, where the exact version number is explicitly given:
 {{{
 +<link rel="stylesheet"
 href="/javascript/jquery/plugins/jpicker/css/jPicker-1.0.11.css"
 type="text/css" />
 +<script type="text/javascript"
 src="/javascript/jquery/plugins/jpicker/jpicker-1.0.11.min.js"></script>
 }}}
 This is I think happening more and more in the code, and I think it makes
 it difficult to upgrade the plugins.  Could we use symbolic links or
 something else that is clever (perhaps in twist.py) to get around this?

 I don't think this is specific to this ticket, so I'm not considering this
 in refereeing this patch.

 ...

 Actually, WOW this is a really nice patch!   It must have been quite a lot
 of work, and really gives the notebook some real added depth.  Thanks!

 Everything looks good.  It works fine.

 William

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7267#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to