#5601: Colors: CSS3/SVG presets, construct from HSL/HSV, lighter/darker methods,
linearly combine
---------------------------+------------------------------------------------
   Reporter:  jason        |       Owner:  was         
       Type:  enhancement  |      Status:  needs_review
   Priority:  minor        |   Milestone:  sage-4.3    
  Component:  graphics     |    Keywords:              
Work_issues:               |      Author:  Mitesh Patel
   Upstream:  N/A          |    Reviewer:              
     Merged:               |  
---------------------------+------------------------------------------------

Comment(by jason):

 This is great stuff.

 Some initial comments:

  # Lots of doctests are marked #random that shouldn't be (there should be
 no #random doctests).  Use ... to take care of memory addresses changing,
 and use sort(dict.items()) to take care of things like dictionaries.

  # .lighter() and .darker() seem to have too little contrast.  Can we make
 it so that they about double their steps?  In other words, can we make it
 so that .lighter() does what .lighter().lighter() does in this patch?

  # Interestingly, colors.white.darker() gives gray values, but
 colors.black.lighter() does not give gray values.

 Of these the first is the real technical issue.  Other things are fine-
 tuning that can be put off to another patch.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5601#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to