#7640: shortest_path should not use NetworkX if the underlying graph is a 
c_graph
----------------------------+-----------------------------------------------
   Reporter:  rlm           |       Owner:  rlm       
       Type:  defect        |      Status:  needs_work
   Priority:  major         |   Milestone:  sage-4.3  
  Component:  graph theory  |    Keywords:            
Work_issues:                |      Author:            
   Upstream:  N/A           |    Reviewer:            
     Merged:                |  
----------------------------+-----------------------------------------------
Changes (by rlm):

  * status:  needs_review => needs_work


Comment:

 Great work!

 A few comments:

 1. You can use `if self._backend.hasattr('_cg')` to test whether self is a
 `c_graph` or a `networkx` graph. This seems cleaner than a try-except
 block.

 2. It should be easy to implement something in the case
 `bidirectional=False`, and we should do this since the point is to replace
 NetworkX with our own functionality.

 3. We also need to handle the case `by_weight=True`: this is only relevant
 for `SparseGraph`s, since `DenseGraph`s don't support edge labeling.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7640#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to