#7678: shorten very long doctests in rings/arith.py
---------------------------+------------------------------------------------
Reporter: AlexGhitza | Owner: tbd
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.3.1
Component: doctest | Keywords:
Work_issues: | Author: Alex Ghitza
Upstream: N/A | Reviewer: John Cremona
Merged: |
---------------------------+------------------------------------------------
Changes (by cremona):
* status: needs_review => needs_work
* reviewer: => John Cremona
Comment:
I see what you did here: (1) you removed tha 'gap' algorithm from the
test, presumably because it was slowest, and (2) instead of testing all i
in each of the ranges 2 to 2255 and 2256 to 5000 you pick 500 random
indices from those ranges and use those.
I don't think that strategy (2) is a good idea, since if this test ever
fails it will be hard to find out exactly where (i.e. for which i). The
tests in our standard test suite should surely be deterministic. What I
did in a similar situation was to once and for all pick a random set of
indices, and make the doctest test those indices only. This does not
prevent us from having a more strenuous test to do on occasion, I am only
proposing limiting what happens every time the whole of Sage is tested.
For that reason (only) I have put this as "needs work", and will post to
sage-devel so that others who commented on your observation can come and
have their say.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7678#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
