#7358: Strong orientations of 2-connected graphs
----------------------------+-----------------------------------------------
Reporter: ncohen | Owner: rlm
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.3.1
Component: graph theory | Keywords:
Work_issues: | Author:
Upstream: N/A | Reviewer:
Merged: |
----------------------------+-----------------------------------------------
Changes (by rlm):
* status: needs_review => needs_work
* upstream: => N/A
Comment:
1. You need to describe what a strongly connected orientation is in your
docstrings.
2. You also need to clearly describe the output, i.e. what type of object
is it...
3. The function shouldn't assume but rather check whether the necessary
conditions are met, and print a helpful error message if they aren't. If
you're concerned about speed, then you can make use of a `check=False`
option.
Other than these minor issues, the patch applies and passes tests, and
looks good.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7358#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
