#7239: factorization of Cunningham numbers
-----------------------------+----------------------------------------------
Reporter: ylchapuy | Owner: tbd
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.3.1
Component: factorization | Keywords: integer factorization Cunningham
Work_issues: | Author: Yann Laigle-Chapuy
Upstream: N/A | Reviewer: John Cremona
Merged: |
-----------------------------+----------------------------------------------
Changes (by cremona):
* keywords: => integer factorization Cunningham
* reviewer: => John Cremona
* status: needs_review => positive_review
Comment:
Sorry for the delay. I have now successfully installed the spkg and
applied the patch (to 4.3.rc0) and everything is working as advertised.
Question: Why the leading underscore in the method
{{{_cunningham_prime_factors()}}}? Like this the function does not show
up in the reference manual or under normal tab completion, so users will
not notice its existence. Since using this is not yet blended in with any
other integer factorization code, I fear that people will not genefit from
this as much as they might.
As far as I can see the spkg itself has everything that it should. So the
positive reivew is for BOTH the inclusion of this as an optional spkg AND
for the merging of the patch.
Now I'll go on to look at the patch which depends on this one.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7239#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
