#7746: Blum-Goldwasser probabilistic encryption
----------------------------+-----------------------------------------------
   Reporter:  mvngu         |       Owner:  mvngu                               
     
       Type:  enhancement   |      Status:  needs_review                        
     
   Priority:  major         |   Milestone:  sage-4.3.1                          
     
  Component:  cryptography  |    Keywords:  Blum-Goldwasser, probabilistic 
encryption
Work_issues:                |      Author:  Minh Van Nguyen                     
     
   Upstream:  N/A           |    Reviewer:                                      
     
     Merged:                |  
----------------------------+-----------------------------------------------

Comment(by wdj):

 This applies and tests fine (modulo the usual failures) on sage-4.3.rc0 on
 a mac running 10.6.2.

 This is definitely a complete reimplementation (as stated in the
 docstring) of Hogan's module, since we actually did a hybrid of the HAC
 version and the Wikipedia version of the algorithm.

 I am not crazy about this:

 {{{

         289         However, if there are no primes between the lower and
 upper bounds,
         290         this function could hang forever. For instance, a
 lower bound of 24 and
         291         an upper bound of 28 would trigger an infinite loop.
 }}}

 It seems to violate the "defensive programming" (or "assume all people are
 stupid") principle that if the is some very bad input which can be
 entered, then you should assume that it *will* be entered at some point.

 Other than this, the patch looks very well documented, gives good
 references and examples. I've forgotten how to compile the docs to see if
 the html comes out okay. Can someone point to a page in the Developers'
 manual of something where html generation is explained? I don't see the
 changes in

 {{{
 sage-4.3.rc0/devel/sage-
 BG-7746/doc/output/html/en/reference/sage/crypto/cryptosystem.html
 }}}

 Finally, some general more-or-less stylistic questions.

 Is SageObject the best superclass for this?

 Is the best place for blum_blum_shub in util or in a stream cipher module?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7746#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--

You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.


Reply via email to