#7616: fix bug in trivial number field extensions
-----------------------------+----------------------------------------------
Reporter: rlm | Owner: rlm
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.3.1
Component: number fields | Keywords:
Work_issues: | Author: Robert Bradshaw, Craig Citro,
Robert Miller
Upstream: N/A | Reviewer: Robert Miller, John Cremona,
Francis Clarke
Merged: |
-----------------------------+----------------------------------------------
Changes (by cremona):
* status: needs_review => positive_review
* reviewer: => Robert Miller, John Cremona, Francis Clarke
Comment:
Disclaimer: Since I did not follow all the discussions between the 2/3
of you, and the only patch I looked at is the most recent one (
trac_7616_alt.patch ) I may be blind to some of the issues here.
The patch applies fine to 4.3.rc0 and all tests in
sage/rings/number_fields pass.
The new code is very well documented both with explanations of what is
being done and why, with references to the underlying pari structures, and
with lots of examples. (I also tried some of my own).
It looks fine to me: I suggest that the best way forward is to pass this,
and if there are some problems further down the line then the explanations
inserted here as comments will make it easier to deal with them. Since I
know that rlm ran into this problem while working on his S-units and
S-class group code, we may find such issues sooner rather than later;
never mind.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7616#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
