#7595: Chinese Remainder Theorem for univariate polynomials over a field
---------------------------+------------------------------------------------
Reporter: rlm | Owner: AlexGhitza
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.3.1
Component: algebra | Keywords:
Work_issues: | Author: Robert Miller
Upstream: N/A | Reviewer: Robert Bradshaw, John Cremona
Merged: |
---------------------------+------------------------------------------------
Changes (by cremona):
* status: needs_review => positive_review
* reviewer: Robert Bradshaw => Robert Bradshaw, John Cremona
* work_issues: needs rebase =>
Comment:
The patch is fine, applies to 4.3.rc0 and all tests pass in sage/rings.
I have some problems with the CRT* functions though.
1. CRT_list does not check that the two lists have the same length; if
the moduli list is shorter you get an IndexError, but it would be better
to catch that and raise a more informative error.
2. CRT_basis is rather silly. It calls CRT_list n times with the same
moduli, which must be wasteful. It would be better to call plain CRT n
times with suitable moduli (exercise for the reader).
Of course, I don't think that these issues should delay the current patch,
but deserve a ticket of their own to make sure they are tided up.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7595#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
